fix(rds): cannot use connections in rds.DatabaseInstance.fromLookup#35193
fix(rds): cannot use connections in rds.DatabaseInstance.fromLookup#35193mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
|
Exemption Request: The fix can be sufficiently validated with unit tests that verify port type conversion, and creating an integration test would require complex setup of dynamically referencing security group IDs between deployment stages. |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
19337e9 to
b9f34da
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35192
Reason for this change
This change fixes an issue in DatabaseInstance.fromLookup() where port values aren't properly converted from strings to numbers.
This causes validation errors when setting up access permissions using the connections interface, as CfnSecurityGroupIngressProps requires port values to be numbers, not strings.
Description of changes
Modified
instance.tsin thefromLookupmethod to convert the port string to a number.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Add a unit test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license