feat(rds): add DatabaseProxyEndpoint L2 construct#35064
feat(rds): add DatabaseProxyEndpoint L2 construct#35064mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
abidhasan-aws
left a comment
There was a problem hiding this comment.
Hi @phuhung273
Thanks for your contribution.
I have left some comments :)
| * | ||
| * @default - CloudFormation-generated name | ||
| */ | ||
| readonly dbProxyEndpointName?: string; |
There was a problem hiding this comment.
For the AWS::RDS::DBProxyEndpoint resource in AWS CloudFormation, the dbProxyEndpointName property is required and is not automatically generated. Suggestion: we can make the field required and update the documentation accordingly.
And even if we want to generate the name, the docs should tell that it's "cdk generated" and not "cloudformation generated"
There was a problem hiding this comment.
It is true that dbProxyEndpointName is required for CloudFormation, CLI,... But I saw the pattern from proxy.ts to take input or generate one and think this way has better user experience.
aws-cdk/packages/aws-cdk-lib/aws-rds/lib/proxy.ts
Lines 461 to 464 in c126e35
So I've updated the docstring to CDK generated. Let me know what you think.
Pull request has been modified.
abidhasan-aws
left a comment
There was a problem hiding this comment.
Thanks for making the changes promptly :)
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #14186
Reason for this change
Add DatabaseProxyEndpoint L2 construct
Description of changes
DatabaseProxyEndpointL2 constructDatabaseProxysupport methodaddEndpointDescribe any new or updated permissions being added
Description of how you validated changes
Unit + Integ
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license