Skip to content

revert: "feat: cloudwatch logs transformer support"#34984

Merged
mergify[bot] merged 2 commits intomainfrom
revert-34863-cloudwatch_logs_transformer_support
Jul 15, 2025
Merged

revert: "feat: cloudwatch logs transformer support"#34984
mergify[bot] merged 2 commits intomainfrom
revert-34863-cloudwatch_logs_transformer_support

Conversation

@leonmk-aws
Copy link
Copy Markdown
Contributor

@leonmk-aws leonmk-aws commented Jul 14, 2025

Reverts #34863

This PR is being reverted because it introduced new enums containing quotes, which exposed a bug in our construct-metadata-updater package. The bug caused the release build to fail.

Since we need to ship a P0 fix in the upcoming release, we're temporarily reverting this PR while we develop a proper long-term solution for handling quoted enum values in the construct-metadata-updater.

@github-actions github-actions bot added the p2 label Jul 14, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team July 14, 2025 14:04
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 14, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@leonmk-aws leonmk-aws changed the title revert "feat: cloudwatch logs transformer support" revert: "feat: cloudwatch logs transformer support" Jul 14, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 14, 2025 14:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 14, 2025
@leonmk-aws leonmk-aws added the pr/do-not-merge This PR should not be merged at this time. label Jul 14, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 15, 2025
@leonmk-aws leonmk-aws removed the pr/do-not-merge This PR should not be merged at this time. label Jul 15, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2b5bb56
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3774f78 into main Jul 15, 2025
18 checks passed
@mergify mergify bot deleted the revert-34863-cloudwatch_logs_transformer_support branch July 15, 2025 09:38
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants