Skip to content

fix(codecov): update codecov-upload.yml action to upload report with correct path#34814

Merged
mergify[bot] merged 2 commits intomainfrom
kumvprat-patch-1
Jun 27, 2025
Merged

fix(codecov): update codecov-upload.yml action to upload report with correct path#34814
mergify[bot] merged 2 commits intomainfrom
kumvprat-patch-1

Conversation

@kumvprat
Copy link
Copy Markdown
Contributor

@kumvprat kumvprat commented Jun 25, 2025

Reason for this change

Fixing the upload path for codecov-upload.ymp based workflow

Description of changes

Last successful run of CodeCov report was https://github.com/aws/aws-cdk/actions/runs/15032809949/job/42248762782
which uploaded to certain path configured in codecov

Uploads after that have been failing silently due to path match failures in codecov

Creating the path ./coverage/packages/aws-cdk-lib/core/coverage and uploading to it should allow code coverage to be populated again

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jun 25, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 25, 2025 17:56
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 25, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@kumvprat kumvprat changed the title Update codecov-upload.yml action to upload report with correct path fix: Update codecov-upload.yml action to upload report with correct path Jun 25, 2025
@kumvprat kumvprat changed the title fix: Update codecov-upload.yml action to upload report with correct path fix(codecov): Update codecov-upload.yml action to upload report with correct path Jun 25, 2025
@kumvprat kumvprat changed the title fix(codecov): Update codecov-upload.yml action to upload report with correct path fix(codecov): update codecov-upload.yml action to upload report with correct path Jun 25, 2025
@kumvprat
Copy link
Copy Markdown
Contributor Author

kumvprat commented Jun 25, 2025

Exemption Request as this is a github workflow change which doesn't need integration or unit testing

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Jun 25, 2025
@vishaalmehrishi
Copy link
Copy Markdown
Contributor

vishaalmehrishi commented Jun 27, 2025

Uploads after that have been failing silently due to path match failures in codecov

Did we change something which caused this?

@kumvprat
Copy link
Copy Markdown
Contributor Author

kumvprat commented Jun 27, 2025

The workflow before : https://github.com/aws/aws-cdk/actions/runs/15032809949/workflow

It was broken into multiple steps here : #34451

With the new workflow style the coverage files are not present in the path that's used by codecov : https://github.com/aws/aws-cdk/actions/runs/15921816999/job/44910111075#step:3:228

@kumvprat kumvprat added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 27, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 27, 2025
@kumvprat kumvprat added the pr-linter/exempt-test The PR linter will not require test changes label Jun 27, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 27, 2025 10:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 27, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2cea408
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 705e76b into main Jun 27, 2025
17 of 18 checks passed
@mergify mergify bot deleted the kumvprat-patch-1 branch June 27, 2025 10:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 27, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vishaalmehrishi vishaalmehrishi vishaalmehrishi approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumvprat @vishaalmehrishi @aws-cdk-automation @Abogical