Skip to content

fix: export errors to make it available in region-info/lib/fact.ts#34691

Merged
mergify[bot] merged 2 commits intomainfrom
iankhou-core-lib-errors-fix
Jun 11, 2025
Merged

fix: export errors to make it available in region-info/lib/fact.ts#34691
mergify[bot] merged 2 commits intomainfrom
iankhou-core-lib-errors-fix

Conversation

@iankhou
Copy link
Copy Markdown
Contributor

@iankhou iankhou commented Jun 11, 2025 •
edited
Loading

Issue #34690

Closes #34690

Reason for this change

PR #33384 released in version 2.200.1 of @aws-cdk/region-info imported UnscopedValidationError from aws-cdk-lib/core/lib/errors, but did not export errors.js properly from aws-cdk-lib. This resulted in the following error message when attempting to import { Fact } from '@aws-cdk/region-info' (fact.ts imports UnscopedValidationError).

❯ node test.js
node:internal/modules/cjs/loader:1228
  throw err;
  ^

Error: Cannot find module 'aws-cdk-lib/core/lib/errors'
Require stack:
- /Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js
- /Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/index.js
- /Volumes/workplace/test-region-info-app/test.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js:8:18)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/fact.js',
    '/Volumes/workplace/test-region-info-app/node_modules/@aws-cdk/region-info/lib/index.js',
    '/Volumes/workplace/test-region-info-app/test.js'
  ]
}

Node.js v20.17.0

Description of changes

Exported errors.js from packages/aws-cdk-lib/package.json, which makes it available to @aws-cdk/region-info.

Describe any new or updated permissions being added

None.

Description of how you validated changes

Tested by hand after making this code change, using example code from the linked issue.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iankhou iankhou self-assigned this Jun 11, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 11, 2025 19:33
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jun 11, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 11, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@iankhou iankhou added p0 and removed p1 labels Jun 11, 2025
@github-actions github-actions bot added p1 and removed p0 labels Jun 11, 2025
@iankhou iankhou added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jun 11, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 11, 2025 19:50

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 11, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 11, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0c367eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 11, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7549fba into main Jun 11, 2025
16 checks passed
@mergify mergify bot deleted the iankhou-core-lib-errors-fix branch June 11, 2025 22:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@iankhou iankhou

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(node: @aws-cdk/region-info): using latest version of @aws-cdk/region-info throws an "Cannot find module 'aws-cdk-lib/core/lib/errors'" error

3 participants

@iankhou @aws-cdk-automation @mrgrain