Skip to content

docs: reflect aws-cdk-lib and CLI split in the contribution guide#34633

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
rantoniuk:patch-1
Jun 5, 2025
Merged

docs: reflect aws-cdk-lib and CLI split in the contribution guide#34633
mergify[bot] merged 2 commits intoaws:mainfrom
rantoniuk:patch-1

Conversation

@rantoniuk
Copy link
Copy Markdown
Contributor

@rantoniuk rantoniuk commented Jun 5, 2025

Remove references to cdk --version check since this doesn't work now after CLI split from aws-cdk.

Closes #34610

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 5, 2025 12:38
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Jun 5, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 5, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cf77c9a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 650f30a into aws:main Jun 5, 2025
10 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2025
@rantoniuk rantoniuk deleted the patch-1 branch June 5, 2025 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrgrain mrgrain mrgrain approved these changes

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

link-all.sh not working as expected

3 participants

@rantoniuk @aws-cdk-automation @mrgrain