Skip to content

fix(logs): query strings can have multiple stats commands#34590

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
msambol:34578
Jul 24, 2025
Merged

fix(logs): query strings can have multiple stats commands#34590
mergify[bot] merged 6 commits intoaws:mainfrom
msambol:34578

Conversation

@msambol
Copy link
Copy Markdown
Contributor

@msambol msambol commented May 30, 2025

Issue #34578

Closes #34578

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels May 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team May 30, 2025 16:54
aws-cdk-automation
aws-cdk-automation previously requested changes May 30, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@msambol msambol changed the title fix(logs): Query strings can multiple stats commands fix(logs): query strings can have multiple stats commands May 30, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 30, 2025 16:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 30, 2025
@github-actions github-actions bot mentioned this pull request Jun 1, 2025
Closed
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Jun 25, 2025

@badmintoncryer Have time for a review here?

badmintoncryer
badmintoncryer approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msambol

Thank you for creating this! I don't think there's any issue with the content.

Just to be safe, how about displaying a warning as an Annotation for users who set both 'stats' and 'statStatements' simultaneously, indicating that 'stats' will be ignored?

ozelalisen
ozelalisen previously requested changes Jul 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments

@ozelalisen ozelalisen self-assigned this Jul 18, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 18, 2025
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Jul 18, 2025

Left minor comments

Added both, thanks for the review!

@mergify mergify bot dismissed ozelalisen’s stale review July 18, 2025 17:57

Pull request has been modified.

@ozelalisen
Copy link
Copy Markdown
Member

ozelalisen commented Jul 21, 2025

Thanks for the changes, could you fix the build failure as well?

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 21, 2025
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Jul 22, 2025

Thanks for the changes, could you fix the build failure as well?

Done!

ozelalisen
ozelalisen previously approved these changes Jul 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ozelalisen ozelalisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 24, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot dismissed ozelalisen’s stale review July 24, 2025 16:01

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jul 24, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0b6a984
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 24, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jul 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 57ae6f9 into aws:main Jul 24, 2025
25 of 26 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 24, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ozelalisen ozelalisen ozelalisen approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@badmintoncryer badmintoncryer badmintoncryer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ozelalisen ozelalisen

Labels

bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(logs): Query strings may multiple stats commands in a single query

5 participants

@msambol @ozelalisen @aws-cdk-automation @badmintoncryer @Abogical