Skip to content

chore: update dev dependency - aws-sdk-js-codemod#34542

Merged
alvazjor merged 11 commits intoaws:mainfrom
leonmk-aws:update-codemod
Jun 11, 2025
Merged

chore: update dev dependency - aws-sdk-js-codemod#34542
alvazjor merged 11 commits intoaws:mainfrom
leonmk-aws:update-codemod

Conversation

@leonmk-aws
Copy link
Copy Markdown
Contributor

@leonmk-aws leonmk-aws commented May 23, 2025 •
edited
Loading

Issue # (if applicable)

Closes #31755.

Reason for this change

The dev dependency is outdated and creates issue for users wanting to use some of the aws-sdk packages in custom resources.

Description of changes

The goal of this change is to update the outdated aws-sdk-js-codemod package to the latest available version (bumping the major version from 0.x.x to 2.x.x).

The following changes have been made:

  1. Updated the aws-sdk-js-codemod
  2. Ran scripts/update-sdkv3-parameters-model.sh
  3. Fixed incorrect IAM prefix generated for CloudWatch actions, see fix(custom-resources): incorrect IAM prefix generated for CloudWatch actions #33078 and doc: https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/permissions-reference-cw.html
  4. Set the feature flag logApiResponseDataPropertyTrueDefault to false (which is the default value) for the tests that needed a snapshot update, as there is a bug that causes the snapshots to be outdated: (integ-tests-alpha,custom-resources): snapshots are always outdated #30583
  5. Ran the tests with --update-on-failed to update snasphots
  6. Reverted the feature flag changes.

Description of how you validated changes

Ran the integration tests and updated the snapshots.

  • framework-integ/test/aws-elasticloadbalancingv2/test/integ.alb.oidc.ts: needs a valid domain so successfully deployed it on my personal account, then regenerated the snapshots with --dry-run --force
  • packages/@aws-cdk-testing/framework-integ/test/aws-elasticloadbalancingv2-actions/test/integ.cognito.js.snapshot/integ-cognito.template.json: needs a valid domain so successfully deployed it on my personal account, then regenerated the snapshots with --dry-run --force

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team May 23, 2025 13:10
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels May 23, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 23, 2025
@leonmk-aws leonmk-aws marked this pull request as ready for review June 2, 2025 12:39
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 2, 2025
@leonmk-aws leonmk-aws marked this pull request as draft June 2, 2025 15:55
@leonmk-aws leonmk-aws added the pr/do-not-merge This PR should not be merged at this time. label Jun 2, 2025
@leonmk-aws leonmk-aws marked this pull request as ready for review June 2, 2025 15:57
@kumsmrit
Copy link
Copy Markdown
Contributor

kumsmrit commented Jun 2, 2025

Please validate whats causing the Security Guardian check to fail.

@leonmk-aws
Copy link
Copy Markdown
Contributor Author

leonmk-aws commented Jun 3, 2025

Please validate what is causing the Security Guardian check to fail.

The security guardian is failing because two tests use overly broad permissions. The snapshots of these tests have changed due to the changes in this pull request. This caused the security-guardian to run on the updated snapshots and report this issue, which is not related to this pull request but to the tests themselves.

@leonmk-aws leonmk-aws removed the pr/do-not-merge This PR should not be merged at this time. label Jun 3, 2025
@alvazjor alvazjor self-assigned this Jun 5, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 5, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@leonmk-aws leonmk-aws added the pr/do-not-merge This PR should not be merged at this time. label Jun 6, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 6, 2025
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 11, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9460749
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@alvazjor
Copy link
Copy Markdown
Contributor

alvazjor commented Jun 11, 2025

Security Guardian failure is complaining about a broad principal permission in the integ tests, specifically when creating the custom KMS key in the opensearch.custom-kms-key and elasticsearch.custom-kms-key. Both are unrelated to this change, and we will add a issue to solve them, as they are out of scope of this change. Merging this manually

@alvazjor alvazjor merged commit dca8663 into aws:main Jun 11, 2025
13 of 14 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 11, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2025
@leonmk-aws leonmk-aws deleted the update-codemod branch August 21, 2025 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumsmrit kumsmrit kumsmrit approved these changes

@alvazjor alvazjor alvazjor approved these changes

Assignees

@alvazjor alvazjor

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p1 pr/do-not-merge This PR should not be merged at this time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(custom-resources): Package @aws-sdk/client-memory-db does not exist

5 participants

@leonmk-aws @kumsmrit @aws-cdk-automation @alvazjor @vishaalmehrishi