feat(sns-subscriptions): support Amazon Data Firehose subscription#33811
feat(sns-subscriptions): support Amazon Data Firehose subscription#33811mergify[bot] merged 16 commits intoaws:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33811 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 120 120
Lines 6938 6938
Branches 1170 1170
=======================================
Hits 5716 5716
Misses 1119 1119
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| 'firehose:PutRecordBatch', | ||
| ], | ||
| resources: [this.deliveryStream.deliveryStreamArn], | ||
| })); |
There was a problem hiding this comment.
You can use the Grant API instead of adding the policies inline (see here).
| import * as sns from '../../../aws-sns'; | ||
| import { ArnFormat, IResource, Token, Stack } from '../../../core'; | ||
|
|
||
| export function regionFromArn(topic: sns.ITopic, resource: IResource): string | undefined { |
| Resource: { 'Fn::GetAtt': ['DeliveryStream58CF96DB', 'Arn'] }, | ||
| }], | ||
| }, | ||
| }); |
There was a problem hiding this comment.
You can add a check to make sure that stack dependencies are set correctly. Add an assertion to check that firehoseStack.dependencies() includes topicStack.
|
@Abogical |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 similar comment
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #14391.
Reason for this change
We can subscribe Amazon Data Firehose delivery streams to Amazon SNS topics.
For details, see https://docs.aws.amazon.com/sns/latest/dg/sns-firehose-as-subscriber.html
Description of changes
Added the
FirehoseSubscriptionintegration class.Describe any new or updated permissions being added
A role will be created to write messages to Firehose.
For details of permissions, see https://docs.aws.amazon.com/sns/latest/dg/prereqs-kinesis-data-firehose.html
Description of how you validated changes
Unit tests and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license