fix(efs): cannot run an integ test when transitionToArchivePolicy is specified and throughputMode is undefined#33713
Conversation
…s specified and `throughputMode` is `undefined`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33713 +/- ##
==========================================
+ Coverage 82.21% 82.37% +0.16%
==========================================
Files 119 120 +1
Lines 6876 6933 +57
Branches 1162 1169 +7
==========================================
+ Hits 5653 5711 +58
+ Misses 1120 1119 -1
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
I thought we could add the validations too and it made sense. But what kind of regression do you think we will see? |
|
@go-to-k The old integration test seems to have worked previously. What do you think about this? |
|
I see. If it doesn't currently work even without validation, like this integ, I didn't think it would be a problem to add validation. However, it is not so necessary that it is forced to be added, so let's leave it as it is just to be safe. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
N/A
Reason for this change
I encountered this problem when fixing a bug. This PR fixes an issue where we cannot rerun test/aws-efs/test/integ.efs-transition.js.
When attempting to rerun this test, the following error is encountered:
The ThroughputMode value for the file system does not support TransitionToArchive. Either change the ThroughputMode value to Elastic or remove the TransitionToArchive parameter.When
throughputModeisundefined, throughput mode is set toBursting.However,
transitionToArchiveis only supported in the Elastic throughput mode. (Ref)Description of changes
Set
throughputModetoElasticwhentransitionToArchivePolicyis specified in a unit test and an integ test.I also considered adding validations. However, I decided against it as it might cause regression issues.
Describe any new or updated permissions being added
Nothing
Description of how you validated changes
Successfully reran the integration test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license