Skip to content

chore(ec2): add VPC interface endpoints for WAFV2#33685

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
yendoooo:wafv2-vpc-endpoints
Mar 7, 2025
Merged

chore(ec2): add VPC interface endpoints for WAFV2#33685
mergify[bot] merged 4 commits intoaws:mainfrom
yendoooo:wafv2-vpc-endpoints

Conversation

@yendoooo
Copy link
Contributor

@yendoooo yendoooo commented Mar 4, 2025 •
edited
Loading

Issue # (if applicable)

Reason for this change

There are no VPC endpoints for AWS WAFV2 so I added.

% aws ec2 describe-vpc-endpoint-services --filters "Name=service-name,Values=*waf*" --region us-east-1 --query "ServiceNames[]" 
[
    "com.amazonaws.us-east-1.wafv2",
    "com.amazonaws.us-east-1.wafv2-fips"
]

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Mar 4, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 4, 2025 17:04
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 4, 2025
badmintoncryer
badmintoncryer approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Mar 4, 2025
@codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (b55199a) to head (707e434).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33685   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@shikha372 shikha372 self-assigned this Mar 5, 2025
shikha372
shikha372 previously approved these changes Mar 6, 2025
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 6, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Mar 6, 2025

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

update

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • any of:
    • sender = {{author}}
    • sender-permission >= write

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Mar 6, 2025

@yendoooo Could you please make a comment @mergify update?

@yendoooo
Copy link
Contributor Author

yendoooo commented Mar 6, 2025

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@yendoooo
Copy link
Contributor Author

yendoooo commented Mar 6, 2025

@badmintoncryer Should I merge latest main branch locally and push again?

@badmintoncryer
Copy link
Contributor

badmintoncryer commented Mar 6, 2025

@yendoooo Let's ask the maintainer for help!

@shikha372 Could you please resolve this mergify problem?

@mergify mergify bot dismissed shikha372’s stale review March 7, 2025 02:00

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 7, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 7, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9532929
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5eb11d2 into aws:main Mar 7, 2025
10 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@shikha372 shikha372 shikha372 approved these changes

@badmintoncryer badmintoncryer badmintoncryer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shikha372 shikha372

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yendoooo @badmintoncryer @aws-cdk-automation @shikha372 @godwingrs22 @samson-keung @SimonCMoore