Skip to content

chore(lambda-nodejs): update integration test for bundling#33679

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
shikha372:shikagg/bundling-root-user
Mar 10, 2025
Merged

chore(lambda-nodejs): update integration test for bundling#33679
mergify[bot] merged 8 commits intoaws:mainfrom
shikha372:shikagg/bundling-root-user

Conversation

@shikha372
Copy link
Contributor

@shikha372 shikha372 commented Mar 4, 2025 •
edited
Loading

Issue # (if applicable)

Closes #NA.

Reason for this change

Plan to change default user to a be non-root for bundling process.

Description of changes

  • Added integration test for all packages that use dockerfile for bundling and will be affected with further changes.
  • Added bootstrap file binary to be identified as an LFS under .gitattribute
  • Updated contributing guide to let users know that git lfs install is needed to handle large file changes.

Describe any new or updated permissions being added

NA

Description of how you validated changes

yarn build
yarn integ

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team March 4, 2025 00:19
@github-actions github-actions bot added the p2 label Mar 4, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 4, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6e0aa13). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33679   +/-   ##
=======================================
  Coverage        ?   82.37%           
=======================================
  Files           ?      120           
  Lines           ?     6933           
  Branches        ?     1169           
=======================================
  Hits            ?     5711           
  Misses          ?     1119           
  Partials        ?      103
Flag Coverage Δ
suite.unit 82.37% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (?)
packages/aws-cdk-lib/core 82.37% <ø> (?)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shikha372 shikha372 changed the title chore(aws-lambda-nodejs): update integration test for bundling chore(lambda-nodejs): update integration test for bundling Mar 4, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 4, 2025 00:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 force-pushed the shikagg/bundling-root-user branch from 3c62f35 to 8afdc75 Compare March 4, 2025 07:07
@shikha372 shikha372 marked this pull request as ready for review March 4, 2025 07:27
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 4, 2025
@shikha372 shikha372 force-pushed the shikagg/bundling-root-user branch from b169227 to 5e1d22a Compare March 8, 2025 01:09
@shikha372 shikha372 force-pushed the shikagg/bundling-root-user branch from 707cd84 to b132234 Compare March 10, 2025 18:36
@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 68133d4 into aws:main Mar 10, 2025
20 checks passed
@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 10, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a19d395
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@moelasmar moelasmar moelasmar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shikha372 @aws-cdk-automation @moelasmar