Skip to content

docs(custom-resources): update installLatestAwsSdk docs to specify correct version#33664

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
longtv2222:fix-aws-custom-resource-docs
Mar 7, 2025
Merged

docs(custom-resources): update installLatestAwsSdk docs to specify correct version#33664
mergify[bot] merged 5 commits intoaws:mainfrom
longtv2222:fix-aws-custom-resource-docs

Conversation

@longtv2222
Copy link
Contributor

@longtv2222 longtv2222 commented Mar 1, 2025 •
edited
Loading

Reason for this change

#31265

The above PR migrated the custom resource from v2 to v3, but the documentation was not updated accordingly. This update ensures the documentation reflects the correct version.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Mar 1, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 1, 2025 09:04
@codecov
Copy link

codecov bot commented Mar 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.37%. Comparing base (34c547c) to head (66343a6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33664   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files         120      120           
  Lines        6933     6933           
  Branches     1169     1169           
=======================================
  Hits         5711     5711           
  Misses       1119     1119           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.37% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 1, 2025
samson-keung
samson-keung previously approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 3, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed samson-keung’s stale review March 4, 2025 21:55

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 4, 2025
@longtv2222 longtv2222 requested a review from samson-keung March 7, 2025 15:06
@longtv2222
Copy link
Contributor Author

longtv2222 commented Mar 7, 2025

Hi @samson-keungwould you mind reviewing this PR again? Seems like Mergify was having some issues earlier

Thanks a bunch!

samson-keung
samson-keung previously approved these changes Mar 7, 2025
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should update or rebase your pull request manually.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify mergify bot dismissed samson-keung’s stale review March 7, 2025 17:02

Pull request has been modified.

samson-keung
samson-keung approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@samson-keung samson-keung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the multiple notifications while I try to fix the auto merge! Please bear with me.

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 7, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 66343a6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7213a2f into aws:main Mar 7, 2025
20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@samson-keung samson-keung samson-keung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@longtv2222 @aws-cdk-automation @samson-keung