Skip to content

chore(fsx): backfill missing enums for fsx#33649

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
paulhcsun:backfill-enums/fsx
Mar 4, 2025
Merged

chore(fsx): backfill missing enums for fsx#33649
mergify[bot] merged 3 commits intoaws:mainfrom
paulhcsun:backfill-enums/fsx

Conversation

@paulhcsun
Copy link
Contributor

@paulhcsun paulhcsun commented Feb 28, 2025 •
edited
Loading

Description of changes

backfill missing enums for fsx

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 28, 2025 23:23
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (7e50699) to head (698e8ad).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33649   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

Leo10Gama
Leo10Gama reviewed Mar 1, 2025
View reviewed changes
@paulhcsun paulhcsun marked this pull request as ready for review March 1, 2025 01:57
@github-actions github-actions bot mentioned this pull request Mar 1, 2025
Closed
@godwingrs22 godwingrs22 self-assigned this Mar 4, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Mar 4, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 698e8ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a8c20dd into aws:main Mar 4, 2025
20 checks passed
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@Leo10Gama Leo10Gama Leo10Gama left review comments

@godwingrs22 godwingrs22 godwingrs22 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@godwingrs22 godwingrs22

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paulhcsun @aws-cdk-automation @godwingrs22 @Leo10Gama @samson-keung