Skip to content

chore: revert unintended snapshot changes due to feature flags#33616

Merged
mergify[bot] merged 3 commits intomainfrom
yuanhaoz/update33291
Feb 28, 2025
Merged

chore: revert unintended snapshot changes due to feature flags#33616
mergify[bot] merged 3 commits intomainfrom
yuanhaoz/update33291

Conversation

@GavinZZ
Copy link
Member

@GavinZZ GavinZZ commented Feb 28, 2025

Reason for this change

#33291

This PR incorrectly updates integration test snapshots without introducing new feature flags. This is causing some issues with local integration test because in local, we expect new feature flag to be default off while in CI, it's expected to be default to true.

Description of changes

Revert back snapshot changes

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Tests pass

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 28, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 28, 2025 01:32
@GavinZZ GavinZZ marked this pull request as ready for review February 28, 2025 01:33
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 28, 2025
@codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (bb4c4d2) to head (efb2174).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33616   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 28, 2025
@xazhao
Copy link
Contributor

xazhao commented Feb 28, 2025

Looks good to me. For the title, it will be included in the revert section of releasing note. Is that intended or should we change it to chore?

@GavinZZ GavinZZ changed the title revert: unintended snapshot changes due to feature flags chore: revert unintended snapshot changes due to feature flags Feb 28, 2025
@GavinZZ
Copy link
Member Author

GavinZZ commented Feb 28, 2025

Updated to 'chore' so that it doesn't show up in the change log

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 28, 2025
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 28, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: efb2174
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8679b89 into main Feb 28, 2025
20 of 21 checks passed
@mergify mergify bot deleted the yuanhaoz/update33291 branch February 28, 2025 19:23
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@paulhcsun paulhcsun paulhcsun approved these changes

@xazhao xazhao xazhao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GavinZZ @xazhao @aws-cdk-automation @paulhcsun