Skip to content

fix(scheduler-targets): update kinesis firehose imports#33615

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
gracelu0:scheduler-update-kinesis-imports
Mar 2, 2025
Merged

fix(scheduler-targets): update kinesis firehose imports#33615
mergify[bot] merged 3 commits intoaws:mainfrom
gracelu0:scheduler-update-kinesis-imports

Conversation

@gracelu0
Copy link
Contributor

Issue # (if applicable)

Closes #.

Reason for this change

The Kinesis Firehose module is now stabilized, need to update package imports accordingly.

Description of changes

Fix import paths for Kinesis Firehose target

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Updated integration test

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 28, 2025 01:16
@github-actions github-actions bot added the p2 label Feb 28, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 28, 2025
Copy link
Contributor

@xazhao xazhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (183556d) to head (fdaf127).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33615   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103           
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

@gracelu0 gracelu0 force-pushed the scheduler-update-kinesis-imports branch from d760d53 to 8030752 Compare March 1, 2025 00:14
@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1df1a78 into aws:main Mar 2, 2025
20 checks passed
@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fdaf127
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants