Skip to content

fix(eks-v2-alpha): can't delete fargate cluster#33573

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
xazhao:fargate-delete
Feb 28, 2025
Merged

fix(eks-v2-alpha): can't delete fargate cluster#33573
mergify[bot] merged 2 commits intoaws:mainfrom
xazhao:fargate-delete

Conversation

@xazhao
Copy link
Contributor

@xazhao xazhao commented Feb 25, 2025 •
edited
Loading

Issue # (if applicable)

Closes #33347.

Reason for this change

The fargate cluster deletion issue is because the cluster admin access entry is deleted before deleting KubernetesPatch.

Since deleting KubernetesPatch requires applying a restore patch to the cluster, it will still need the cluster access. In this case, because the access entry is deleted, kubectl provider won't be able to apply the patch to the cluster anymore.

Description of changes

add an explicit dependency from patch to the access entry so the patch will only be deleted after the access entry

Description of how you validated changes

unit tests/integration tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 25, 2025 01:50
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Feb 25, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 25, 2025
@codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (528e5df) to head (3b35344).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33573   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         119      119           
  Lines        6876     6876           
  Branches     1162     1162           
=======================================
  Hits         5653     5653           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.21% <ø> (ø)

GavinZZ
GavinZZ reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to set LAMBDA_CREATE_NEW_POLICIES_WITH_ADDTOROLEPOLICY? I see you mentioned in description that without this it will create new policy when running the test. Is this happening in main as well?

@GavinZZ GavinZZ self-assigned this Feb 26, 2025
@xazhao
Copy link
Contributor Author

xazhao commented Feb 26, 2025

@GavinZZ yes without this change, I see integration tests failed with following changes:

[~] AWS::IAM::Policy ClusterKubectlProviderframeworkonEventServiceRoleDefaultPolicyA4F24629
 └─ [~] PolicyDocument
     └─ [~] .Statement:
         └─ @@ -24,5 +24,15 @@
            [ ]         ]
            [ ]       }
            [ ]     ]
            [+]   },
            [+]   {
            [+]     "Action": "lambda:GetFunction",
            [+]     "Effect": "Allow",
            [+]     "Resource": {
            [+]       "Fn::GetAtt": [
            [+]         "ClusterKubectlProviderHandler2E05C68A",
            [+]         "Arn"
            [+]       ]
            [+]     }
            [ ]   }
            [ ] ]

It only happens in my local though. CodeBuild looks fine. I'm not sure if it happens to other people.

aws-cdk-automation
aws-cdk-automation previously requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@GavinZZ GavinZZ added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Feb 28, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 28, 2025 01:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 28, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3b35344
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4ada313 into aws:main Feb 28, 2025
20 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2025
@xazhao xazhao deleted the fargate-delete branch March 26, 2025 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GavinZZ GavinZZ

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eks-v2-alpha: can't delete fargate cluster

4 participants

@xazhao @aws-cdk-automation @GavinZZ @samson-keung