Skip to content

chore(cognito-identitypool-alpha): remove unused awslint condition#33550

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
Leo10Gama:idp-lint
Feb 22, 2025
Merged

chore(cognito-identitypool-alpha): remove unused awslint condition#33550
mergify[bot] merged 3 commits intoaws:mainfrom
Leo10Gama:idp-lint

Conversation

@Leo10Gama
Copy link
Copy Markdown
Contributor

@Leo10Gama Leo10Gama commented Feb 21, 2025

Issue # (if applicable)

N/A

Reason for this change

A previous PR removed the IdentityPoolRoleAttachmentProps interface, so the linting exclusion is not necessary anymore.

Description of changes

Removed unused linting exclusion from aws-cognito-identitypool-alpha/awslint.json.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

yarn build && yarn test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 21, 2025 23:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 21, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (63ec7f9) to head (0057131).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33550   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5639     5639           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 22, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0057131
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 22, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c4ae041 into aws:main Feb 22, 2025
20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 22, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2025
@Leo10Gama Leo10Gama deleted the idp-lint branch February 24, 2025 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Leo10Gama @aws-cdk-automation @kaizencc @GavinZZ