chore(cognito-identitypool-alpha): add assertions to integ test#33549
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Feb 21, 2025
Merged
chore(cognito-identitypool-alpha): add assertions to integ test#33549mergify[bot] merged 2 commits intoaws:mainfrom
mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33549 +/- ##
=======================================
Coverage 82.17% 82.17%
=======================================
Files 119 119
Lines 6862 6862
Branches 1158 1158
=======================================
Hits 5639 5639
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/A
Reason for this change
To put these integration tests more in-line with the rest in the repository and ensure tests are comprehensive, added assertions to validate that the
IdentityPoolconstruct is deployed with the correct parameters.Description of changes
Added assertions against the Cognito calls for
DescribeIdentityPoolCommand(doc ref) andGetIdentityPoolRolesCommand(doc ref).Describe any new or updated permissions being added
N/A
Description of how you validated changes
yarn integ test/integ.identitypool.jspasses and the tests deploy.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license