fix(core): serviceTimeout for CustomResource does not work with token#33541
fix(core): serviceTimeout for CustomResource does not work with token#33541mergify[bot] merged 5 commits intoaws:mainfrom
serviceTimeout for CustomResource does not work with token#33541Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33541 +/- ##
==========================================
+ Coverage 82.17% 82.20% +0.02%
==========================================
Files 119 119
Lines 6862 6862
Branches 1158 1158
==========================================
+ Hits 5639 5641 +2
+ Misses 1120 1118 -2
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Exemption Request: This could be covered by unit tests only. |
|
@Mergifyio update |
☑️ Nothing to doDetails
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33513.
Reason for this change
The
serviceTimeoutforCustomResourcedoes not work with token.The way the token is handled is wrong, and the
isUnresolvedmethod that theDurationtype has should be used.Description of changes
Use the
props.serviceTimeout.isUnresolved().Also add a doc that the token must be specified in
Duration.seconds()since it is converted bytoSecondsinternally. (Because it is a token and unknown MINUTES value cannot be converted to SECONDS. This is due to the token mechanism.)see:
https://github.com/go-to-k/aws-cdk/blob/75e52619cd09f363882ff62561a53cd5cd79ab30/packages/aws-cdk-lib/core/lib/custom-resource.ts#L169
https://github.com/go-to-k/aws-cdk/blob/75e52619cd09f363882ff62561a53cd5cd79ab30/packages/aws-cdk-lib/core/lib/duration.ts#L332
Describe any new or updated permissions being added
Description of how you validated changes
Unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license