chore: update stale pr workflow#33537
Conversation
|
@mergify update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
@mergify update |
☑️ Nothing to doDetails
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33537 +/- ##
=======================================
Coverage 82.20% 82.20%
=======================================
Files 119 119
Lines 6862 6862
Branches 1158 1158
=======================================
Hits 5641 5641
Misses 1118 1118
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
||
| To prevent automatic closure: | ||
| - Fix merge conflicts | ||
| - OR request an exemption by adding a comment containing 'Exemption Request' with justification e.x "Exemption Request: <justification>" |
There was a problem hiding this comment.
After they request exemption and we review it, what label do we need to give to not prevent it to close? pr/do-not-close? This doesn't quite feel the same as the typical flow with exemption request.
Just curious if a maintainer didn't add do-not-close label and the PR was simply put into exemption requested state, would it stop the automation to close it?
There was a problem hiding this comment.
Yea the maintainer would have to put do-not-close or leave the exemption label there. If they remove the label and don't add the do-not-close label then the PR could be considered stale.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@mergify update |
☑️ Nothing to doDetails
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
Messaging around stale PRs isn't clear, contributors don't always know what the next steps are if their PR is considered stale.
Also, response time for contributors is too short. IMO 7 days isn't enough to get back to our comments as we sometimes take a long time to review PRs. Open to discussion on what the window for response time should be
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license