Skip to content

chore: add remote branch check to workflows#33525

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
gracelu0:add-remote-check-to-workflows
Feb 20, 2025
Merged

chore: add remote branch check to workflows#33525
mergify[bot] merged 2 commits intoaws:mainfrom
gracelu0:add-remote-check-to-workflows

Conversation

@gracelu0
Copy link
Copy Markdown
Contributor

@gracelu0 gracelu0 commented Feb 20, 2025

Issue # (if applicable)

n/a

Reason for this change

Adhere to best security practices.

Description of changes

Fetch remote branch to check for any unapproved commits to the remote branch and only commit/push if there are not.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Tested the commands locally

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 20, 2025 18:23
@github-actions github-actions bot added the p2 label Feb 20, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 20, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (1b116b9) to head (93be3d7).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33525   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5639     5639           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 20, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 20, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 93be3d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 20, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 241bda3 into aws:main Feb 20, 2025
20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GavinZZ GavinZZ

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gracelu0 @aws-cdk-automation @GavinZZ