chore(appsync): improve error message for missing iam authorization mode#33501
chore(appsync): improve error message for missing iam authorization mode#33501mergify[bot] merged 7 commits intoaws:mainfrom
Conversation
|
Seems like the PR includes a lot of formatting changes, which are not compatible with the linting setup in the repo. |
1c05580 to
c8ee4db
Compare
|
You will need to change this test as well: https://github.com/garysassano/aws-cdk/blob/8b20e712a35ae7b5150bbfabfc94246ae4307745/packages/aws-cdk-lib/aws-appsync/test/appsync-eventapi.test.ts#L364 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33501 +/- ##
=======================================
Coverage 82.17% 82.17%
=======================================
Files 119 119
Lines 6862 6862
Branches 1158 1158
=======================================
Hits 5639 5639
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33465
Reason for this change
The error message when using grant methods like
grantPublish()andgrantSubscribe()on an Event API without IAM authorization mode needs improvement. Currently, users get a confusing error without clear guidance on how to fix it.The error should clearly explain:
Description of changes
Rephrased the error message.
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license