Skip to content

chore(ec2): add Windows Server 2025 to WindowsVersion enum#33499

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
invalidexplorer:dev/featureAdd
Feb 19, 2025
Merged

chore(ec2): add Windows Server 2025 to WindowsVersion enum#33499
mergify[bot] merged 4 commits intoaws:mainfrom
invalidexplorer:dev/featureAdd

Conversation

@invalidexplorer
Copy link
Copy Markdown
Contributor

@invalidexplorer invalidexplorer commented Feb 18, 2025

Issue # (if applicable)

Closes #33497 (aws-ec2): Add Windows Server 2025 to WindowsVersion enum

Reason for this change

The AWS License Manager team requires Windows Server 2025 support in the WindowsVersion enum to build production-ready EC2 image pipelines.

Description of changes

Added new enum values in packages/@aws-cdk/aws-ec2/lib/windows-versions.ts:

WINDOWS_SERVER_2025_ENGLISH_FULL_BASE = 'Windows_Server-2025-English-Full-Base',
WINDOWS_SERVER_2025_ENGLISH_CORE_BASE = 'Windows_Server-2025-English-Core-Base'
  • No breaking changes introduced
  • Maintains consistent naming convention with existing enum values
  • Describe any new or updated permissions being added
  • No new IAM permissions are required for this change as it only extends the existing enum with additional values.

Description of how you validated changes

Existing Unit Tests:

  • Ran all existing unit tests to ensure no regressions
  • Confirmed all tests pass successfully with the new enum values added

Manual Testing:

  • Tested in development environment
  • Verified correct AMI resolution using the new enum values

Checklist

[x] My code adheres to the CONTRIBUTING GUIDE
[x] My code adheres to the DESIGN GUIDELINES
[ ] Added new unit tests (No new tests added, verified against existing tests)
[ ] Added integration tests (Manual testing performed)
[x] Followed existing enum naming conventions

@aws-cdk-automation aws-cdk-automation requested a review from a team February 18, 2025 22:50
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Feb 18, 2025
GavinZZ
GavinZZ approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (b16fac2) to head (031b0c2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33499   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         119      119           
  Lines        6857     6857           
  Branches     1157     1157           
=======================================
  Hits         5634     5634           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.16% <ø> (ø)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 19, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 031b0c2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3b7cf94 into aws:main Feb 19, 2025
20 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 19, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-ec2): Add Windows Server 2025 to WindowsVersion enum

3 participants

@invalidexplorer @aws-cdk-automation @GavinZZ