Skip to content

feat(codepipeline-actions): support timeout for ManualApprovalAction#33472

Merged
mergify[bot] merged 11 commits intoaws:mainfrom
go-to-k:cp-actions-manual-timeout
Feb 19, 2025
Merged

feat(codepipeline-actions): support timeout for ManualApprovalAction#33472
mergify[bot] merged 11 commits intoaws:mainfrom
go-to-k:cp-actions-manual-timeout

Conversation

@go-to-k
Copy link
Copy Markdown
Contributor

@go-to-k go-to-k commented Feb 17, 2025 •
edited
Loading

Issue # (if applicable)

Closes #33473

Reason for this change

The TimeoutInMinutes property, which is for the manual approval action, has been added to ActionDeclaration in CFn, but not yet added to ManualApprovalAction in CDK.

A timeout duration in minutes that can be applied against the ActionType’s default timeout value specified in Quotas for AWS CodePipeline. This attribute is available only to the manual approval ActionType.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-actiondeclaration.html#cfn-codepipeline-pipeline-actiondeclaration-timeoutinminutes

Other ref: https://docs.aws.amazon.com/codepipeline/latest/userguide/limits.html

Manual approval action account level default timeout: 7 days

Note
The default timeout for the manual approval action can be overridden for a specific action in the pipeline, and it is configurable up to 86400 minutes (60 days) with a minimum value of 5 minutes. For more information, see ActionDeclaration in the CodePipeline API Reference.

When configured, this timeout is applied for the action. Otherwise, the account level default is used.

Description of changes

Added timeout to ManualApprovalActionProps and other related properties (such as Action, FullActionDescriptor and Stage).

Describe any new or updated permissions being added

Description of how you validated changes

Both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 17, 2025 07:23
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Feb 17, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): add timeout for ManualApprovalAction feat(codepipeline-actions): add timeout for ManualApprovalAction Feb 17, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): add timeout for ManualApprovalAction feat(codepipeline-actions): support timeout for ManualApprovalAction Feb 17, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 17, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review February 17, 2025 07:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@go-to-k go-to-k marked this pull request as ready for review February 17, 2025 07:54
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (3b7cf94) to head (17ef8a2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33472   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         119      119           
  Lines        6857     6857           
  Branches     1157     1157           
=======================================
  Hits         5634     5634           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.16% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 17, 2025
@github-actions github-actions bot added the feature-request A feature should be added or improved. label Feb 17, 2025
GavinZZ
GavinZZ previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 18, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review February 18, 2025 23:20

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k
Copy link
Copy Markdown
Contributor Author

go-to-k commented Feb 19, 2025

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2025

update

☑️ Nothing to do

Details
  • #commits-behind > 0 [📌 update requirement]
  • queue-position = -1 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@go-to-k
Copy link
Copy Markdown
Contributor Author

go-to-k commented Feb 19, 2025

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2025

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details
  • sender-permission >= write

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 19, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 17ef8a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7901f07 into aws:main Feb 19, 2025
20 checks passed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 19, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 19, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2025
@go-to-k go-to-k deleted the cp-actions-manual-timeout branch February 19, 2025 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

codepipeline-actions: support timeout for manual approval action

3 participants

@go-to-k @aws-cdk-automation @GavinZZ