Skip to content

chore(s3): update annotation phrase of addReplicationPolicy()#33459

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
badmintoncryer:fix-annotation
Feb 18, 2025
Merged

chore(s3): update annotation phrase of addReplicationPolicy()#33459
mergify[bot] merged 3 commits intoaws:mainfrom
badmintoncryer:fix-annotation

Conversation

@badmintoncryer
Copy link
Contributor

@badmintoncryer badmintoncryer commented Feb 15, 2025 •
edited
Loading

Issue # (if applicable)

None

Reason for this change

As mentioned in this comment, the annotation phrase is incorrect and may confuse users.
The addReplicationPolicy() function works to add a resource policy for the destination bucket, but the annotation phrase says source bucket.

Description of changes

- For Cross-account S3 replication, ensure to set up permissions on source bucket using method addReplicationPolicy() 
+ For Cross-account S3 replication, ensure to set up permissions on destination bucket using method addReplicationPolicy()

Describe any new or updated permissions being added

None

Description of how you validated changes

None

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 15, 2025 00:07
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Feb 15, 2025
@badmintoncryer badmintoncryer changed the title chore(s3): update annotation of addReplicationPolicy() chore(s3): update annotation phrase of addReplicationPolicy() Feb 15, 2025
@codecov
Copy link

codecov bot commented Feb 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (8f3e793) to head (8812db6).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33459   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         119      119           
  Lines        6857     6857           
  Branches     1157     1157           
=======================================
  Hits         5634     5634           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.16% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 15, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 17, 2025
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8eeb8e4 into aws:main Feb 18, 2025
20 checks passed
@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 18, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8812db6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
@badmintoncryer badmintoncryer deleted the fix-annotation branch February 19, 2025 00:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@go-to-k go-to-k go-to-k approved these changes

@aaythapa aaythapa aaythapa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@badmintoncryer @aws-cdk-automation @go-to-k @aaythapa