Skip to content

chore: fix workflows#33457

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
gracelu0:fix-workflows
Feb 15, 2025
Merged

chore: fix workflows#33457
mergify[bot] merged 2 commits intoaws:mainfrom
gracelu0:fix-workflows

Conversation

@gracelu0
Copy link
Copy Markdown
Contributor

@gracelu0 gracelu0 commented Feb 14, 2025

Issue # (if applicable)

n/a

Reason for this change

Checking out the head.sha puts us into 'detached HEAD' state

You are in 'detached HEAD' state. You can look around, make experimental
  changes and commit them, and you can discard any commits you make in this
  state without impacting any branches by switching back to a branch.

so the workflow will fail during the commit/push step:

Run git config --global user.name 'aws-cdk-automation'
[detached HEAD 0364b3fc] chore: update analytics metadata blueprints
 3 files changed, 121 insertions(+), 121 deletions(-)
error: src refspec bump/2.179.0 does not match any
error: failed to push some refs to 'https://github.com/aws/aws-cdk'
Error: Process completed with exit code 1.

Description of changes

Checkout the branch head ref just before we commit changes in the workflow.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Tested on release branch, workflow successfully ran.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 14, 2025 21:55
@github-actions github-actions bot added the p2 label Feb 14, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (0e67605) to head (a767b78).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33457   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         238      238           
  Lines       14271    14271           
  Branches     2492     2492           
=======================================
  Hits        11560    11560           
  Misses       2425     2425           
  Partials      286      286           
Flag Coverage Δ
suite.unit 81.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.92% <ø> (ø)
packages/aws-cdk-lib/core 82.16% <ø> (ø)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 14, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 085c2e3 into aws:main Feb 15, 2025
20 checks passed
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a767b78
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants