feat(rds): scheduling modifications in the next scheduled maintenance window by Tietew · Pull Request #33448 · aws/aws-cdk

Tietew · 2025-02-14T07:05:31Z

Issue # (if applicable)

Reason for this change

CloudFormation has added applyImmediately feature to RDS instances.
This allows to schedule modifications in the next scheduled maintenance window.
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_ModifyInstance.ApplyImmediately.html

Description of changes

Added applyImmediately prop to DatabaseInstanceNewProps and ClusterInstanceOptions.
To schedule modifications, specify applyImmediately: false in instance props.

new rds.DatabaseInstance(this, 'Instance', {
  // ...
  applyImmediately: false,
});

new rds.DatabaseCluster(this, 'Cluster', {
  // ...
  writer: rds.ClusterInstance.serverlessV2('writer', {
    applyImmediately: false,
  }),
});

Note: Currently, applyImmediately is not supported in the cluster configurations.

Describe any new or updated permissions being added

Nothing

Description of how you validated changes

Unit tests and integ tests.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Tietew · 2025-02-14T07:11:09Z

Added integration tests verify the applyImmediately property is deployed successfully.
But I'm unsure how to test modifications are actually scheduled.

codecov · 2025-02-14T07:17:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (f9b28b9) to head (23ebddc).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33448   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5639     5639           
  Misses       1120     1120           
  Partials      103      103

Flag	Coverage Δ
suite.unit	`82.17% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`82.17% <ø> (ø)`

lpizzinidev

Thanks 👍 Only one minor doc adjustment imo

packages/aws-cdk-lib/aws-rds/lib/instance.ts

GavinZZ

LGTM, thanks you for the contribution!

mergify · 2025-02-19T22:55:05Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-19T22:59:07Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-19T22:59:18Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Pull request has been modified.

Tietew · 2025-02-20T01:29:30Z

@lpizzinidev Good catch. Fixed.

Tietew · 2025-02-20T01:38:46Z

Build failed due to #33481

Waiting for @aws-cdk/aws-service-spec v0.1.53 or higher. see #33445 for spec changes.

├[~] service aws-rds
│ └ resources
│    ├[~]  resource AWS::RDS::DBInstance
│    │  └ properties
│    │     └[+] ApplyImmediately: boolean

GavinZZ · 2025-02-20T20:29:39Z

@Tietew yes, unfortunately we reverted the schema change in the previous release. I'm working on the next release which should include this change.

Tietew · 2025-02-21T10:19:30Z

@GavinZZ
#33531 is shipped in 2.180.0.
Could you please take a look at this PR again?

mergify · 2025-02-21T18:38:14Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-21T18:38:18Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify · 2025-02-21T18:42:32Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

GavinZZ · 2025-02-21T19:27:05Z

@Mergifyio requeue

mergify · 2025-02-21T19:27:30Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-02-21T19:27:47Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Pull request has been modified.

mergify · 2025-02-21T21:38:20Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2025-02-21T22:09:41Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 23ebddc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-02-21T22:09:54Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-02-21T22:10:05Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

Tietew added 5 commits February 14, 2025 13:40

add applyImmediately

5b45794

integ tests

0e67fc2

README

013770d

fix docstrings

77959e4

fix section levels

5b1b2ba

github-actions bot added feature-request A feature should be added or improved. p2 labels Feb 14, 2025

aws-cdk-automation requested a review from a team February 14, 2025 07:05

github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Feb 14, 2025

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 14, 2025

Merge branch 'main' into rds-apply-immediately

c68bfbe

lpizzinidev approved these changes Feb 19, 2025

View reviewed changes

packages/aws-cdk-lib/aws-rds/lib/instance.ts Outdated Show resolved Hide resolved

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 19, 2025

GavinZZ previously approved these changes Feb 19, 2025

View reviewed changes

GavinZZ self-assigned this Feb 19, 2025

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 19, 2025

Tietew added 2 commits February 20, 2025 10:22

Merge branch 'main' into rds-apply-immediately

2abd15b

update doc

d34c042

Merge branch 'main' into rds-apply-immediately

52169ed

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 21, 2025

Tietew requested a review from GavinZZ February 21, 2025 10:19

Merge branch 'main' into rds-apply-immediately

bf472c7

GavinZZ previously approved these changes Feb 21, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 21, 2025

Merge branch 'main' into rds-apply-immediately

dfa407e

GavinZZ approved these changes Feb 21, 2025

View reviewed changes

Merge branch 'main' into rds-apply-immediately

23ebddc

mergify bot merged commit be2c7d0 into aws:main Feb 21, 2025
20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025

Tietew deleted the rds-apply-immediately branch February 22, 2025 01:31

Conversation

Tietew commented Feb 14, 2025

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

Tietew commented Feb 14, 2025

Uh oh!

codecov bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lpizzinidev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

GavinZZ left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 19, 2025

Uh oh!

mergify bot commented Feb 19, 2025

Uh oh!

mergify bot commented Feb 19, 2025

Uh oh!

Tietew commented Feb 20, 2025

Uh oh!

Tietew commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GavinZZ commented Feb 20, 2025

Uh oh!

Tietew commented Feb 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

GavinZZ commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

aws-cdk-automation commented Feb 21, 2025

AWS CodeBuild CI Report

Uh oh!

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 14, 2025 •

edited

Loading

Tietew commented Feb 20, 2025 •

edited

Loading

Tietew commented Feb 21, 2025 •

edited

Loading