Skip to content

fix(stepfunctions): support assign property and fix Catch state issue#33423

Merged
GavinZZ merged 3 commits intoyuanhaoz/sfn-jsonata-fixfrom
yuanhaoz/sfn-jsonata-fix2
Feb 13, 2025
Merged

fix(stepfunctions): support assign property and fix Catch state issue#33423
GavinZZ merged 3 commits intoyuanhaoz/sfn-jsonata-fixfrom
yuanhaoz/sfn-jsonata-fix2

Conversation

@GavinZZ
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ commented Feb 12, 2025 •
edited
Loading

Issue # (if applicable)

Closes #33403 and #33374 and #33396.

Reason for this change

There are three issues here:

  1. For summary, the first issue is basically that assign property cannot be accessed with using Map.jsonata(...) but available if we directly create map through new Map(...) using JSONATA query language.
  2. For summary, the second issue is that JSONATA main PR added the outputs and assign property in the CatchProps interface for AddCatch functionality. But I don't think it's being used in the actual addCatch call https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-stepfunctions/lib/states/state.ts#L398.
  3. Result writer and item reader class do not support using JSONATA. Deployment will fails due to if SFN is set to use JSONATA, it expects Arguments in the ASL instead of Parameters.

Description of changes

Fix both issues by fixing the interface inheritance and added the props to AddCatch method.
Support JSONATA as the query language.

Description of how you validated changes

Added integ test and unit test to make sure that

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@GavinZZ GavinZZ added the pr-linter/exempt-readme The PR linter will not require README changes label Feb 12, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 12, 2025
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Feb 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 12, 2025 23:15
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (a7d7373) to head (7c21328).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #33423      +/-   ##
==========================================
- Coverage   80.92%   80.90%   -0.03%     
==========================================
  Files         236      236              
  Lines       14255    14261       +6     
  Branches     2491     2493       +2     
==========================================
+ Hits        11536    11538       +2     
- Misses       2434     2438       +4     
  Partials      285      285
Flag Coverage Δ
suite.unit 80.90% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <ø> (ø)
packages/aws-cdk-lib/core 82.16% <ø> (-0.05%) ⬇️

aws-cdk-automation
aws-cdk-automation requested changes Feb 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 12, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7c21328
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@GavinZZ GavinZZ changed the base branch from main to yuanhaoz/sfn-jsonata-fix February 13, 2025 00:34
@GavinZZ GavinZZ merged commit e7f46cb into yuanhaoz/sfn-jsonata-fix Feb 13, 2025
22 of 26 checks passed
@GavinZZ GavinZZ deleted the yuanhaoz/sfn-jsonata-fix2 branch February 13, 2025 00:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

No one assigned

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

step functions: Map.jsonata does not support assign

2 participants

@GavinZZ @aws-cdk-automation