Skip to content

fix(cli): cdk diff fails when deploy role requires tags#33340

Merged
mergify[bot] merged 2 commits intomainfrom
otaviom/send-tags-changeset
Feb 7, 2025
Merged

fix(cli): cdk diff fails when deploy role requires tags#33340
mergify[bot] merged 2 commits intomainfrom
otaviom/send-tags-changeset

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

@otaviomacedo otaviomacedo commented Feb 7, 2025

The call to createChangeSet is not passing that stack's tags. If the deploy role has some policy that requires specific tags, it will fail to create a change set and, therefore, to create a diff.

Pass the tags along to createChangeSet.

Fixes #33316.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@otaviomacedo otaviomacedo requested a review from a team as a code owner February 7, 2025 17:15
@github-actions github-actions bot added the bug This issue is a bug. label Feb 7, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 7, 2025 17:16
@github-actions github-actions bot added effort/medium Medium work item – several days of effort p1 labels Feb 7, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 7, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 7, 2025

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (4744ee5) to head (1f2a1c8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #33340      +/-   ##
==========================================
+ Coverage   80.83%   80.92%   +0.08%     
==========================================
  Files         236      236              
  Lines       14251    14253       +2     
  Branches     2490     2490              
==========================================
+ Hits        11520    11534      +14     
+ Misses       2446     2434      -12     
  Partials      285      285
Flag Coverage Δ
suite.unit 80.92% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.73% <100.00%> (+0.16%) ⬆️
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@kaizencc kaizencc added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Feb 7, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 7, 2025 20:43

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 7, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1f2a1c8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 7, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f1d9a7d into main Feb 7, 2025
18 of 19 checks passed
@mergify mergify bot deleted the otaviom/send-tags-changeset branch February 7, 2025 23:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 7, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cdk-toolkit: cdk diff failed to create a ChangeSet due to missing tagging

3 participants

@otaviomacedo @aws-cdk-automation @kaizencc