fix: do not skip bundling for stacks during CDK Import, otherwise fails#33322
fix: do not skip bundling for stacks during CDK Import, otherwise fails#33322mergify[bot] merged 7 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33322 +/- ##
=======================================
Coverage 80.92% 80.92%
=======================================
Files 236 236
Lines 14253 14253
Branches 2490 2490
=======================================
Hits 11534 11534
Misses 2434 2434
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6e09df6 to
2becfd2
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issues #31999 #31677
Closes #31999 #31677
Reason for this change
cdk importreports changes in the stack when none are present, for NodeJS Lambda functions. This results in the command failing. The only way to work around this is to use the --force flag, which replaces stack resources. This is not ideal as it overwrites existing resources that may contain data, and is just generally unnecessary.Description of changes
I added
cdk importto a configuration that determines which CLI commands bundle code. Before this change,cdk importskipped code bundling. This is fine for regular Lambda functions that don't rely on bundling. However, NodeJSFunction does.The original implementation of skipping bundling for certain CLI commands was introduced via Issue #9540.
cdk importwas introduced two years later in PR #17666.Describe any new or updated permissions being added
No permissions changes.
Description of how you validated changes
I added an integration test in
packages/@aws-cdk-testing/framework-integ/test/aws-lambda-nodejs/test/integ.nodejs.build.images.ts.The test ensures that NodeJSFunction Lambdas are always bundled. I will add a canary in a follow-up PR to ensure that new CLI commands are explicitly determined to either need or not need bundling.
I manually validated changes:
iankhou-1738867338384cdk synth,cdk deployon a stack with a NodeJSFunction, and without an S3 bucketcdk importOutput and console:
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license