Skip to content

chore(mergify): update priority for new rule#33303

Merged
mergify[bot] merged 1 commit intoaws:mainfrom
shikha372:mergify_priority
Feb 5, 2025
Merged

chore(mergify): update priority for new rule#33303
mergify[bot] merged 1 commit intoaws:mainfrom
shikha372:mergify_priority

Conversation

@shikha372
Copy link
Copy Markdown
Contributor

@shikha372 shikha372 commented Feb 5, 2025

Issue # (if applicable)

Closes NA

Reason for this change

Moving rule position to update the priority in order to fix freezing rules.
If a queue with high priority is frozen, the ones below it will also be under freeze as well, which is not the desired state that we want. Priority should be higher for queue rule priority-squash so that we can successfully freeze the default-squash one.

Description of changes

Moving rule position to update the priority in order to fix freezing rules.

Describe any new or updated permissions being added

NA

Description of how you validated changes

NA

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Feb 5, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 5, 2025 20:29
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 5, 2025
@moelasmar moelasmar added the pr/no-squash This PR should be merged instead of squash-merging it label Feb 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (a8e2622) to head (a14bcfa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33303   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         236      236           
  Lines       14253    14253           
  Branches     2490     2490           
=======================================
  Hits        11522    11522           
  Misses       2446     2446           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.57% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a14bcfa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 5, 2025

Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 20176e6 into aws:main Feb 5, 2025
40 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr/no-squash This PR should be merged instead of squash-merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants