feat(kinesisfirehose): graduate to stable 🚀 by paulhcsun · Pull Request #33296 · aws/aws-cdk

paulhcsun · 2025-02-04T22:29:06Z

Issue # (if applicable)

Closes #7536.

Description of changes

We are excited to graduate the @aws-cdk/aws-kinesisfirehose-alpha and @aws-cdk/aws-kinesisfirehose-destinations-alpha modules to STABLE.

They now live on as aws-cdk-lib/aws-kinesisfirehose.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

codecov · 2025-02-04T22:41:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (bc96ee1) to head (0412ae5).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33296   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files         236      236           
  Lines       14253    14253           
  Branches     2490     2490           
=======================================
  Hits        11522    11522           
  Misses       2446     2446           
  Partials      285      285

Flag	Coverage Δ
suite.unit	`80.83% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`79.57% <ø> (ø)`
packages/aws-cdk-lib/core	`82.20% <ø> (ø)`

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aaythapa

🚀

paulhcsun · 2025-02-04T23:33:43Z

@Mergifyio update

mergify · 2025-02-04T23:33:51Z

update

☑️ Nothing to do

Details

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

need changes

packages/aws-cdk-lib/rosetta/aws_kinesisfirehose/default.ts-fixture

packages/aws-cdk-lib/aws-kinesisfirehose/lib/private/helpers.ts

aaythapa · 2025-02-05T00:09:19Z

...ages/@aws-cdk-testing/framework-integ/test/aws-kinesisfirehose/test/lambda-data-processor.js

@@ -0,0 +1,12 @@
+export async function handler(event, context) {


Should be moved under integ-assets can be done in subsequent PRs

mergify · 2025-02-05T01:07:50Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-05T01:29:54Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

moelasmar · 2025-02-05T03:37:34Z

@mergify update

mergify · 2025-02-05T03:37:37Z

update

☑️ Nothing to do

Details

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

moelasmar · 2025-02-05T03:37:52Z

@mergify refresh

mergify · 2025-02-05T03:38:12Z

refresh

✅ Pull request refreshed

aws-cdk-automation · 2025-02-05T04:10:08Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 0412ae5
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-02-05T04:10:29Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-02-05T04:10:46Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

paulhcsun added 3 commits February 3, 2025 23:01

feat(aws-kinesisfirehose): graduate to stable 🚀

1b1a077

README updates + update stability banners

e73eaac

fix stability banner

3cdb915

aws-cdk-automation requested a review from a team February 4, 2025 22:29

github-actions bot added effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 labels Feb 4, 2025

mergify bot added the contribution/core This is a PR that came from AWS. label Feb 4, 2025

aws-cdk-automation previously requested changes Feb 4, 2025

View reviewed changes

fix test imports

853639a

paulhcsun changed the title ~~feat(aws-kinesisfirehose): graduate to stable 🚀~~ feat(kinesisfirehose): graduate to stable 🚀 Feb 4, 2025

paulhcsun marked this pull request as ready for review February 4, 2025 23:13

Merge branch 'main' into kinesisfirehose-alpha-module-graduation

ba31b31

paulhcsun and others added 2 commits February 4, 2025 15:20

fix integ test import

a0b6826

Merge branch 'main' into kinesisfirehose-alpha-module-graduation

ee993ac

aaythapa previously approved these changes Feb 4, 2025

View reviewed changes

update incorrect import

d0084c0

aaythapa reviewed Feb 4, 2025

View reviewed changes

packages/aws-cdk-lib/rosetta/aws_kinesisfirehose/default.ts-fixture Show resolved Hide resolved

moelasmar reviewed Feb 4, 2025

View reviewed changes

packages/aws-cdk-lib/aws-kinesisfirehose/lib/private/helpers.ts Outdated Show resolved Hide resolved

paulhcsun added 4 commits February 4, 2025 15:46

remove extra / in helper imports

36b99d0

add lambda-data-processor file

b7d3442

update import order

6fd089f

fix import in index.ts

07dac8b

aaythapa reviewed Feb 5, 2025

View reviewed changes

aaythapa approved these changes Feb 5, 2025

View reviewed changes

remove duplicate import

d2a6d21

GavinZZ approved these changes Feb 5, 2025

View reviewed changes

Merge branch 'main' into kinesisfirehose-alpha-module-graduation

0412ae5

mergify bot merged commit 7aaac12 into aws:main Feb 5, 2025
19 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2025

paulhcsun deleted the kinesisfirehose-alpha-module-graduation branch February 5, 2025 08:11

		@@ -0,0 +1,12 @@
		export async function handler(event, context) {

Conversation

paulhcsun commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Description of changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aaythapa left a comment

Choose a reason for hiding this comment

Uh oh!

paulhcsun commented Feb 4, 2025

Uh oh!

mergify bot commented Feb 4, 2025

☑️ Nothing to do

Uh oh!

Uh oh!

Uh oh!

aaythapa Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 5, 2025

Uh oh!

mergify bot commented Feb 5, 2025

The merge conditions cannot be satisfied due to failing checks:

Uh oh!

moelasmar commented Feb 5, 2025

Uh oh!

mergify bot commented Feb 5, 2025

☑️ Nothing to do

Uh oh!

moelasmar commented Feb 5, 2025

Uh oh!

mergify bot commented Feb 5, 2025

✅ Pull request refreshed

Uh oh!

aws-cdk-automation commented Feb 5, 2025

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Feb 5, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

paulhcsun commented Feb 4, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Feb 4, 2025 •

edited

Loading