feat(cognito): throw ValidationError instead of untyped errors#33170
feat(cognito): throw ValidationError instead of untyped errors#33170mergify[bot] merged 1 commit intoaws:mainfrom
ValidationError instead of untyped errors#33170Conversation
|
Exemption Request: This PR only replace Error to ValidationError. |
|
To maintainers: If there are any issues, feel free to close this PR :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33170 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 232 232
Lines 14110 14110
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2430 2430
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
lpizzinidev
left a comment
There was a problem hiding this comment.
👍 Please fix the typo in the title (intsead) and surround ValidationError with backticks
ValidationError instead of untyped errors
mrgrain
left a comment
There was a problem hiding this comment.
Thank you, really appreciate this!
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
aws-cognitofor #32569Description of changes
ValidationErrors everywhere
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Existing tests. Exemptions granted as this is basically a refactor of existing code.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license