Skip to content

feat(custom-resource): update default node runtime to node20 for China and Gov regions#33112

Merged
mergify[bot] merged 9 commits intoaws:mainfrom
xazhao:update-node
Jan 28, 2025
Merged

feat(custom-resource): update default node runtime to node20 for China and Gov regions#33112
mergify[bot] merged 9 commits intoaws:mainfrom
xazhao:update-node

Conversation

@xazhao
Copy link
Copy Markdown
Contributor

@xazhao xazhao commented Jan 24, 2025 •
edited
Loading

Reason for this change

Node18 is being deprecated in most regions. So we should make custom resource use node 20 as default runtime in china and us-gov regions.

Description of changes

Update LATEST_NODE_RUNTIME_MAP so cdk will use node20 as default runtime for custom resource.

Description of how you validated changes

Unit tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2025 00:14
@github-actions github-actions bot added the p2 label Jan 24, 2025
@xazhao xazhao added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed p2 labels Jan 24, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 24, 2025
@github-actions github-actions bot added the p2 label Jan 24, 2025
@xazhao
Copy link
Copy Markdown
Contributor Author

xazhao commented Jan 24, 2025

A few integration tests need to be updated as well

@xazhao
Copy link
Copy Markdown
Contributor Author

xazhao commented Jan 24, 2025

Updated failed integration tests

@xazhao xazhao requested a review from a team as a code owner January 24, 2025 18:50
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (69b25da) to head (07453a0).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33112   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files         232      232           
  Lines       14111    14111           
  Branches     2453     2453           
=======================================
  Hits        11400    11400           
  Misses       2431     2431           
  Partials      280      280
Flag Coverage Δ
suite.unit 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.51% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

aws-cdk-automation
aws-cdk-automation previously requested changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

GavinZZ
GavinZZ approved these changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GavinZZ GavinZZ added the pr/do-not-merge This PR should not be merged at this time. label Jan 24, 2025
@GavinZZ
Copy link
Copy Markdown
Member

GavinZZ commented Jan 24, 2025

Added a do-not-merge until you fix the integ tests.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 24, 2025 20:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

aws-cdk-automation
aws-cdk-automation previously requested changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

aws-cdk-automation
aws-cdk-automation previously requested changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed stale reviews from themself January 24, 2025 20:34

Dismissing outdated PRLinter review.

aws-cdk-automation
aws-cdk-automation previously requested changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 24, 2025 22:00

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@xazhao xazhao removed the pr/do-not-merge This PR should not be merged at this time. label Jan 28, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 28, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 07453a0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8c13cf2 into aws:main Jan 28, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 28, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 28, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2025
@xazhao xazhao deleted the update-node branch March 26, 2025 20:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xazhao @GavinZZ @aws-cdk-automation