Skip to content

chore(eslint): enforce no extra semicolons#33101

Closed
kaizencc wants to merge 10 commits intomainfrom
conroy/remove-unnecessary-semicolon-2
Closed

chore(eslint): enforce no extra semicolons#33101
kaizencc wants to merge 10 commits intomainfrom
conroy/remove-unnecessary-semicolon-2

Conversation

@kaizencc
Copy link
Copy Markdown
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from a team as a code owner January 23, 2025 17:00
@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2025 17:01
@github-actions github-actions bot added the p2 label Jan 23, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 23, 2025
@kaizencc kaizencc marked this pull request as draft January 23, 2025 17:03
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.53%. Comparing base (e4703c1) to head (c33a682).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33101   +/-   ##
=======================================
  Coverage   81.52%   81.53%           
=======================================
  Files         224      226    +2     
  Lines       13762    13769    +7     
  Branches     2414     2414           
=======================================
+ Hits        11220    11227    +7     
  Misses       2270     2270           
  Partials      272      272           
Flag Coverage Δ
suite.unit 81.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.92% <ø> (-0.01%) ⬇️
packages/aws-cdk-lib/core 82.17% <ø> (+0.02%) ⬆️

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c33a682
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc
Copy link
Copy Markdown
Contributor Author

#33095 was merged! yay!

@kaizencc kaizencc closed this Jan 27, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants