Skip to content

feat: throw ValidationError instead of untyped errors in L1s#33032

Merged
mergify[bot] merged 2 commits intomainfrom
mrgrain/feat/l1/validation-error
Jan 27, 2025
Merged

feat: throw ValidationError instead of untyped errors in L1s#33032
mergify[bot] merged 2 commits intomainfrom
mrgrain/feat/l1/validation-error

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Jan 21, 2025

Issue

All L1s for #32569

Description of changes

Updated the codegen to throw the correct error.
Instead of

throw new Error("Unexpected IResolvable");

we now throw

throw new errors.ValidationError("Unexpected IResolvable", scope);

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Existing tests. Exemptions granted as this is basically a refactor of existing code.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-codecov The PR linter will not require codecov checks to pass labels Jan 21, 2025
@github-actions github-actions bot added the p2 label Jan 21, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2025 13:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 21, 2025
@mrgrain mrgrain changed the title feat: use ValidationError in L1s feat: throw ValidationError instead of untyped errors in L1s Jan 21, 2025
kaizencc
kaizencc previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but i assume you'll want to wait until s3/validation-error is merged?

Base automatically changed from mrgrain/fix/s3/validation-error to main January 21, 2025 16:46
@mrgrain mrgrain requested a review from a team as a code owner January 21, 2025 16:46
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (918a3a8) to head (43a99b5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33032   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files         232      232           
  Lines       14111    14111           
  Branches     2453     2453           
=======================================
  Hits        11400    11400           
  Misses       2431     2431           
  Partials      280      280
Flag Coverage Δ
suite.unit 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.51% <ø> (ø)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@mrgrain mrgrain marked this pull request as draft January 21, 2025 17:26
@mrgrain mrgrain dismissed kaizencc’s stale review January 21, 2025 17:27

This will need more changes. Dismissing review to force a re-review later.

@mrgrain
Copy link
Copy Markdown
Contributor Author

mrgrain commented Jan 21, 2025 •
edited
Loading

Drafting the PR. This clearly needs more work.
Work completed.

@mrgrain mrgrain force-pushed the mrgrain/feat/l1/validation-error branch from a08e441 to 1f6baae Compare January 27, 2025 13:21
@mrgrain mrgrain force-pushed the mrgrain/feat/l1/validation-error branch from 1f6baae to 1550647 Compare January 27, 2025 13:46
@mrgrain mrgrain marked this pull request as ready for review January 27, 2025 15:00
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 27, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 43a99b5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1b666db into main Jan 27, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the mrgrain/feat/l1/validation-error branch January 27, 2025 18:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 27, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-codecov The PR linter will not require codecov checks to pass pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrgrain @aws-cdk-automation @kaizencc