Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33006 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 232 232
Lines 14110 14110
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2430 2430
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
||
| // The read replica instance always uses the same engine as the source instance | ||
| // but some CF validations require the engine to be explicitely passed when some | ||
| // but some CF validations require the engine to be explicitly passed when some |
There was a problem hiding this comment.
Single quotes is the preferred formatting style for the library and it should be used in the documentation for consistency. Can you please adjust?
kaizencc
left a comment
There was a problem hiding this comment.
Thanks for the community reviews @lpizzinidev. I agree, I would prefer just a single PR with all these changes and that will save all of us some time :). Thanks for your eagle eyes (and/or spell check integration) @andyu17!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
Fixed typos in code comments.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license