Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32969 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 226 226
Lines 13768 13768
Branches 2416 2416
=======================================
Hits 11219 11219
Misses 2271 2271
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| * For code that requires an exception | ||
| */ | ||
| public actionsToException(actions: LinterActions) { | ||
| if (actions.requestChanges) { |
There was a problem hiding this comment.
Was this always the logic? only fail the linter if it requests changes?
mrgrain
left a comment
There was a problem hiding this comment.
I trust you to fix problems
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The PR linter code was a bit of a mess; evaluating rules and mutating the PR was interspersed, generic GitHub code was mixed with CDK-specific code, the linter could be triggered from multiple sources, none of them were documented very well.
Try to rectify all of that in this PR to make it easier to extend the PR linter in the future:
Not every crazy design decision has been rectified yet, but at least we have a start of something a little more comprehensible. Another change I made: the old PR linter creates a comment + a review with the same content (but not quite). In this PR, make it just do reviews and don't do comments.
This started from a PR that had CodeCov changes added, but I want to do a refactor without feature changes first before adding new code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license