chore(toolkit): watch action#32951
Merged
mrgrain merged 12 commits intomrgrain/toolkit-pocfrom Jan 15, 2025
Merged
Conversation
mrgrain
reviewed
Jan 15, 2025
| import { asSdkLogger, withAction, Timer, confirm, data, error, highlight, info, success, warn, ActionAwareIoHost } from './api/io/private'; | ||
| import { asSdkLogger, withAction, Timer, confirm, data, error, highlight, info, success, warn, ActionAwareIoHost, debug } from './api/io/private'; | ||
|
|
||
| const PROJECT_CONFIG = 'cdk.json'; |
Contributor
There was a problem hiding this comment.
We can import this I think
mrgrain
reviewed
Jan 15, 2025
Comment on lines
+470
to
+471
| const rootDir = path.dirname(path.resolve(PROJECT_CONFIG)); | ||
| await ioHost.notify(debug(`root directory used for 'watch' is: ${rootDir}`)); |
Contributor
There was a problem hiding this comment.
This should just become an option on the interface
mrgrain
reviewed
Jan 15, 2025
| public async watch(cx: ICloudAssemblySource, options: WatchOptions): Promise<void> { | ||
| const ioHost = withAction(this.ioHost, 'watch'); | ||
| throw new Error('Not implemented yet'); | ||
| const rootDir = options.rootDir ?? path.dirname(path.resolve(PROJECT_CONFIG)); |
Contributor
There was a problem hiding this comment.
I don't think this line is doing what it claims to do path.resolve is just appending cdk.json to the CWD and then we take the dirname of that. Which is also just the CWD.
mrgrain
reviewed
Jan 15, 2025
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cdk watch builds in toolkit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license