Skip to content

chore(toolkit): cloud assemblies#32947

Merged
mrgrain merged 2 commits intomrgrain/toolkit-pocfrom
mrgrain/chore/cxapps
Jan 15, 2025
Merged

chore(toolkit): cloud assemblies#32947
mrgrain merged 2 commits intomrgrain/toolkit-pocfrom
mrgrain/chore/cxapps

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Jan 15, 2025 •
edited
Loading

Description of changes

Adds support for creating cloud assemblies from the 3 main sources:

  • A builder function
  • A CDK app dir
  • A cdk.out dir

Describe any new or updated permissions being added

n/a

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner January 15, 2025 15:03
@github-actions github-actions bot added the p2 label Jan 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2025 15:03
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 15, 2025
aws-cdk-automation
aws-cdk-automation requested changes Jan 15, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jan 15, 2025
@mrgrain mrgrain force-pushed the mrgrain/chore/cxapps branch from 3d1ba18 to 66d64dc Compare January 15, 2025 15:10
@mrgrain mrgrain force-pushed the mrgrain/chore/cxapps branch from 66d64dc to f4f3915 Compare January 15, 2025 16:06
kaizencc
kaizencc approved these changes Jan 15, 2025
View reviewed changes
packages/@aws-cdk/toolkit/lib/api/io/private/logger.ts
};
}

// @todo these cannot be awaited WTF
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@mrgrain mrgrain merged commit 992fabd into mrgrain/toolkit-poc Jan 15, 2025
1 check passed
@mrgrain mrgrain deleted the mrgrain/chore/cxapps branch January 15, 2025 17:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 15, 2025

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/32947/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

@kaizencc kaizencc kaizencc approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr/needs-cli-test-run This PR needs CLI tests run against it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrgrain @aws-cdk-automation @kaizencc