Skip to content

fix(rds): incorrect version definition of MySQL 8.4.3#32934

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
Tietew:rds-fix-mysql84-version
Jan 15, 2025
Merged

fix(rds): incorrect version definition of MySQL 8.4.3#32934
mergify[bot] merged 2 commits intoaws:mainfrom
Tietew:rds-fix-mysql84-version

Conversation

@Tietew
Copy link
Copy Markdown
Contributor

@Tietew Tietew commented Jan 15, 2025

Issue # (if applicable)

Closes #32933.

Reason for this change

The major version definition of MySQL 8.4.3 is incorrect.

Description of changes

Fixed the major version definition of MySQL 8.4.3.

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Jan 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2025 10:32
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (ec73658) to head (0e9060d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32934   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files         223      223           
  Lines       13727    13727           
  Branches     2411     2411           
=======================================
  Hits        11175    11175           
  Misses       2274     2274           
  Partials      278      278           
Flag Coverage Δ
suite.unit 81.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.74% <ø> (ø)
packages/aws-cdk-lib/core 82.10% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 15, 2025
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this was my mistake.
Thanks for the correction.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 15, 2025
@kaizencc kaizencc changed the title chore(rds): fix version definition of MySQL 8.4.3 fix(rds): incorrect version definition of MySQL 8.4.3 Jan 15, 2025
@kaizencc kaizencc added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 15, 2025
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jan 15, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 15, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 0e9060d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 15, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3fbc785 into aws:main Jan 15, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
@Tietew Tietew deleted the rds-fix-mysql84-version branch January 17, 2025 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rds: cannot create RDS MySQL 8.4.3

4 participants