chore(toolkit): enforce codes at compile time#32893
Merged
HBobertz merged 4 commits intobobertzh/CliIoHostfrom Jan 13, 2025
Merged
chore(toolkit): enforce codes at compile time#32893HBobertz merged 4 commits intobobertzh/CliIoHostfrom
HBobertz merged 4 commits intobobertzh/CliIoHostfrom
Conversation
aws-cdk-automation
previously requested changes
Jan 13, 2025
Collaborator
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
…ge-code-validation
HBobertz
approved these changes
Jan 13, 2025
Contributor
HBobertz
left a comment
There was a problem hiding this comment.
made some changes so g2g now
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
Instead of running regexp at runtime, we validate message codes at compile time
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license