@kaizencc, could you please review this PR? The previous one had some issues and required constant updates. I’ve created a new PR from a recently updated fork and a new branch. I hope this resolves the issues, and it works as expected this time.

@pahud can you please review this PR?

@azarboon there are 2 issues, sort of.

About the first that you mentioned, where the PR keeps saying the branch is out-of-date. This is not a problem. The reason this happens is because the aws-cdk repo has a lot of commits all the time so PR branches are usually out-of-date very quickly. But that is okay. As long as the PR does not have conflicts with the new merged commits. Once the PR is approved to merge, we have automation set up that will update the PR with latest main branch automatically and handle the merge into main. So don't worry about it!

However, for this PR, I see there is an error on the Codecov check. To work around the issue, can you try closing this PR, then re-open a new one from the same branch you have?

@azarboon there are 2 issues, sort of.

About the first that you mentioned, where the PR keeps saying the branch is out-of-date. This is not a problem. The reason this happens is because the aws-cdk repo has a lot of commits all the time so PR branches are usually out-of-date very quickly. But that is okay. As long as the PR does not have conflicts with the new merged commits. Once the PR is approved to merge, we have automation set up that will update the PR with latest main branch automatically and handle the merge into main. So don't worry about it!

However, for this PR, I see there is an error on the Codecov check. To work around the issue, can you try closing this PR, then re-open a new one from the same branch you have?

@samson-keung Thanks for your response and explanation. Following your instructions, I’ve created a new PR (#32982). As discussed in another issue, I’m using Windows, so to minimize potential issues, I created the new PR via the GitHub UI. Unfortunately, I couldn’t reuse the previous branch and had to create a new one instead. The change is minimal and only affects the README file, so it shouldn’t impact any tests.

Let me know your advice.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (2b2443d) to head (4781427).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main   #32889   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files         226      226           
  Lines       13768    13768           
  Branches     2416     2416           
=======================================
  Hits        11219    11219           
  Misses       2271     2271           
  Partials      278      278           

@azarboon there are 2 issues, sort of.

About the first that you mentioned, where the PR keeps saying the branch is out-of-date. This is not a problem. The reason this happens is because the aws-cdk repo has a lot of commits all the time so PR branches are usually out-of-date very quickly. But that is okay. As long as the PR does not have conflicts with the new merged commits. Once the PR is approved to merge, we have automation set up that will update the PR with latest main branch automatically and handle the merge into main. So don't worry about it!

However, for this PR, I see there is an error on the Codecov check. To work around the issue, can you try closing this PR, then re-open a new one from the same branch you have?

@samson-keung To prevent future misunderstandings, could you please elaborate on where you see the Codedev error? From my side, there are no failed automated checks. Please see the screenshot below for reference:

Additionally, here is the automated response from Codedev:

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (2b2443d) to head (4781427).

Additional details and impacted files

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 4781427
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@azarboon Thanks. I see that check re-ran after you updated the branch again. And this time it passed. The CodeBuild job also re-ran but since I have approved this PR, once the CodeBuild is done, this PR will be auto-merged.

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.