Skip to content

feat(aws-cognito): L2 Construct support for analytics configuration#32865

Closed
wladyslawczyzewski wants to merge 1 commit intoaws:mainfrom
wladyslawczyzewski:l2_construct_support_for_analytics_configuration
Closed

feat(aws-cognito): L2 Construct support for analytics configuration#32865
wladyslawczyzewski wants to merge 1 commit intoaws:mainfrom
wladyslawczyzewski:l2_construct_support_for_analytics_configuration

Conversation

@wladyslawczyzewski
Copy link
Copy Markdown
Contributor

@wladyslawczyzewski wladyslawczyzewski commented Jan 12, 2025

Issue # (if applicable)

Closes #32837.

Reason for this change

To configure the analytics support for Cognito's App client we were required to use workaround and modify the the underlying L1 cloudformation's construct.

Description of changes

Added parameter to the UserPoolClient props.
Added validation for these parameters.
Added unit and integration tests.

Describe any new or updated permissions being added

No permissions changed.

Description of how you validated changes

  1. Unit tests
  2. Integration tests
  3. Deployed on own AWS env for one of my projects.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jan 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 12, 2025 13:12
aws-cdk-automation
aws-cdk-automation requested changes Jan 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 12, 2025

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ The title of the pull request should omit 'aws-' from the name of modified packages. Use 'cognito' instead of 'aws-cognito'.
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 12, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2c35136
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-cognito): L2 Construct support for analytics configuration

2 participants

@wladyslawczyzewski @aws-cdk-automation