chore(cli): rename _ to command in UserInput#32822
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
_ to command in UserInput. _ to command in UserInput
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32822 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 222 222
Lines 13717 13717
Branches 2417 2417
=======================================
Hits 11183 11183
Misses 2254 2254
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
This does not change CLI functionality because
UserInputis not in use yet. Since we have full control overUserInput, i.e. we control the input functions from the CLI orcdk.json, we can rename properties however we like._is a relic ofyargs, we do not need to maintain that convention.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license