chore: codecov includes files outside of configured packages#32748
Merged
mergify[bot] merged 1 commit intomainfrom Jan 6, 2025
Merged
chore: codecov includes files outside of configured packages#32748mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
rix0rrr
approved these changes
Jan 6, 2025
mrgrain
approved these changes
Jan 6, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32748 +/- ##
===========================================
+ Coverage 66.91% 81.38% +14.47%
===========================================
Files 329 222 -107
Lines 18684 13750 -4934
Branches 3260 2423 -837
===========================================
- Hits 12503 11191 -1312
+ Misses 5854 2279 -3575
+ Partials 327 280 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition of
aws-cdk-lib/corecaused other files fromaws-cdk-libto be included in the report.The undesired included files are those that are imported by
aws-cdk-lib/coreunit tests. And since they are in the same package, they are included in the jest report. We could exclude them from jest, but that would mean changing the coverage settings for the entireaws-cdk-libpackage. Instead, we can ask codecov to ignore them. Compare the previous report with this one, from my fork, that tests the new configuration.