Skip to content

feat(eks): update nodegroup gpu check#32715

Merged
mergify[bot] merged 11 commits intoaws:mainfrom
paulhcsun:nodegroup-gpu-instance-types
Jan 6, 2025
Merged

feat(eks): update nodegroup gpu check#32715
mergify[bot] merged 11 commits intoaws:mainfrom
paulhcsun:nodegroup-gpu-instance-types

Conversation

@paulhcsun
Copy link
Contributor

@paulhcsun paulhcsun commented Jan 2, 2025 •
edited
Loading

Issue # (if applicable)

Closes #31347.

Reason for this change

The motivating bug is that you cannot add a combo of g5 and a g6 as instance classes onto the same node group or else the following error will be thrown: instanceTypes of different architectures is not allowed.

Description of changes

  • (eks) Fixes the isGpuInstanceType check
    • G6/G6E instance classes will now be recognized as GPU instance types so those different types can be used together for a multi instance type managed node group

Description of how you validated changes

Wrote unit tests for the isGpuInstanceType function

Checklist

Duplicate of #31445, originally authored by @ AlexKaracaoglu

Co-authored-by: Alex Karacaoglu AlexKaracaoglu@users.noreply.github.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Jan 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 2, 2025 21:19
@paulhcsun paulhcsun marked this pull request as ready for review January 2, 2025 21:19
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 2, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@paulhcsun paulhcsun added the pr-linter/exempt-readme The PR linter will not require README changes label Jan 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 2, 2025 21:26

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (f809b94) to head (e4f72e3).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32715   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         222      222           
  Lines       13750    13750           
  Branches     2424     2424           
=======================================
  Hits        11191    11191           
  Misses       2279     2279           
  Partials      280      280
Flag Coverage Δ
suite.unit 81.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@paulhcsun paulhcsun mentioned this pull request Jan 2, 2025
Closed
1 task
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 2, 2025
aaythapa
aaythapa reviewed Jan 2, 2025
View reviewed changes
5d
5d reviewed Jan 2, 2025
View reviewed changes
@paulhcsun
Copy link
Contributor Author

paulhcsun commented Jan 6, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 6, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun
Copy link
Contributor Author

paulhcsun commented Jan 6, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

update

✅ Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@paulhcsun
Copy link
Contributor Author

paulhcsun commented Jan 6, 2025

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

update

☑️ Nothing to do

Details
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jan 6, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e4f72e3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 693afea into aws:main Jan 6, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2025
@paulhcsun paulhcsun deleted the nodegroup-gpu-instance-types branch January 6, 2025 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@5d 5d 5d approved these changes

@aaythapa aaythapa aaythapa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-eks: manage nodegroups GPU instance types not up to date

4 participants

@paulhcsun @aws-cdk-automation @5d @aaythapa