chore(eks-v2-alpha): remove nested stack#32692
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32692 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 222 222
Lines 13715 13715
Branches 2417 2417
=======================================
Hits 11181 11181
Misses 2254 2254
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e41cb16 to
12ecc13
Compare
There was a problem hiding this comment.
I see few unit test cases are removed. Is this expected? If not, can those unit test can also be updated to check based on main stack?
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
In the current EKS module,
kubectlProvideris created in a nested stack. The nested stack here is not necessary and hence moving it to the main stack.Description of changes
Move
kubectlProviderto the main stack.Describe any new or updated permissions being added
<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->
Description of how you validated changes
Updated unit tests so they all passed
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license