Skip to content

feat(bedrock): additional foundation models#32684

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
mazyu36:berdrock-missing-models
Dec 31, 2024
Merged

feat(bedrock): additional foundation models#32684
mergify[bot] merged 5 commits intoaws:mainfrom
mazyu36:berdrock-missing-models

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Dec 30, 2024 •
edited
Loading

Add some missing foundation models IDs.

% aws bedrock list-foundation-models --region us-west-2 | jq -r '.modelSummaries[].modelId'

The following models are missing:

  • anthropic.claude-3-5-sonnet-20241022-v2:0:18k
  • anthropic.claude-3-5-sonnet-20241022-v2:0:200k
  • anthropic.claude-3-5-sonnet-20241022-v2:0:51k
  • meta.llama3-3-70b-instruct-v1:0
  • stability.sd3-5-large-v1:0
  • stability.stable-image-core-v1:1
  • stability.stable-image-ultra-v1:1

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 30, 2024 12:41
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Dec 30, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.95%. Comparing base (56ed0e5) to head (14c5650).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32684   +/-   ##
=======================================
  Coverage   66.95%   66.95%           
=======================================
  Files         329      329           
  Lines       18662    18662           
  Branches     3257     3257           
=======================================
  Hits        12496    12496           
  Misses       5839     5839           
  Partials      327      327
Flag Coverage Δ
suite.unit 66.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.08% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 30, 2024
lpizzinidev
lpizzinidev reviewed Dec 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to create a single PR given that #32597 is not yet merged 🤔

@mazyu36 mazyu36 mentioned this pull request Dec 30, 2024
Closed
1 task
@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Dec 30, 2024

@lpizzinidev
Thanks. I’ve merged #32597 changes to this PR.

GavinZZ
GavinZZ previously approved these changes Dec 30, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 30, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@GavinZZ
Copy link
Copy Markdown
Member

GavinZZ commented Dec 30, 2024

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 30, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 30, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 30, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 30, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Dec 31, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 31, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@mergify mergify bot dismissed GavinZZ’s stale review December 31, 2024 03:30

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 31, 2024
lpizzinidev
lpizzinidev approved these changes Dec 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lpizzinidev lpizzinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 31, 2024
@kaizencc kaizencc changed the title chore(bedrock): add missing foundation models feat(bedrock): additional foundation models Dec 31, 2024
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Dec 31, 2024
@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Dec 31, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 31, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 31, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 14c5650
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fcf4ecd into aws:main Dec 31, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 31, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
@mazyu36 mazyu36 deleted the berdrock-missing-models branch December 31, 2024 23:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

+2 more reviewers

@lpizzinidev lpizzinidev lpizzinidev approved these changes

@GavinZZ GavinZZ GavinZZ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mazyu36 @GavinZZ @aws-cdk-automation @lpizzinidev @kaizencc